[Remind-Fans] [PATCH] Remove autogenerated files from autotools.

Simon Ruderich simon at ruderich.org
Sun Jan 19 13:07:46 EST 2014


---
Hello,

This patches removes auto-generated files from the source tree.
To regenerate them, autoreconf -fsi can be used as usual.
Generated tarballs are not affected.

Adding generated files to a VCS is considered bad practice
(unnecessary duplication and it makes reviewing the code harder)
and in this case it also removes duplication in src/config.h.in,
which can be automatically generated from configure.ac.

I've been using this patch for a while and remind builds fine.

I removed the part of the diff which removes configure because
it's very big; you must remove it manually and then amend the
commit.

Regards
Simon

 .gitignore      |    2 +
 configure       | 5232 -------------------------------------------------------
 configure.in    |    1 +
 src/config.h.in |   39 -
 4 files changed, 3 insertions(+), 5271 deletions(-)
 delete mode 100755 configure
 delete mode 100644 src/config.h.in

diff --git a/.gitignore b/.gitignore
index 3831d3e..d630568 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,10 +2,12 @@
 autom4te.cache
 config.log
 config.status
+configure
 src/Makefile
 www/Makefile
 *.o
 src/config.h
+src/config.h.in
 src/remind
 src/*.tar.gz*
 tests/test.out
diff --git a/configure.in b/configure.in
index 1562fa7..d933c66 100644
--- a/configure.in
+++ b/configure.in
@@ -13,6 +13,7 @@ cat <<'EOF'
 EOF
 
 AC_CONFIG_HEADER(src/config.h)
+AH_BOTTOM([#include "custom.h"])
 
 if test "`uname -s`" = "Darwin" ; then
    trap 'echo Be patient...' INT TERM
diff --git a/src/config.h.in b/src/config.h.in
deleted file mode 100644
index 5518ca8..0000000
--- a/src/config.h.in
+++ /dev/null
@@ -1,39 +0,0 @@
-/* Define if utime(file, NULL) sets file's timestamp to the present.  */
-#undef HAVE_UTIME_NULL
-
-/* Define if you can safely include both <sys/time.h> and <time.h>.  */
-#undef TIME_WITH_SYS_TIME
-
-/* Define if your <sys/time.h> declares struct tm.  */
-#undef TM_IN_SYS_TIME
-
-/* Define if you have the <sys/file.h> header file.  */
-#undef HAVE_SYS_FILE_H
-
-/* Define if you have the <glob.h> header file */
-#undef HAVE_GLOB_H
-
-#undef HAVE_WCTYPE_H
-
-#undef HAVE_LOCALE_H
-
-#undef HAVE_GLOB
-
-#undef HAVE_SETENV
-
-#undef HAVE_UNSETENV
-
-#undef HAVE_MBSTOWCS
-
-#undef HAVE_SETLOCALE
-
-/* The number of bytes in a unsigned int.  */
-#undef SIZEOF_UNSIGNED_INT
-
-/* The number of bytes in a unsigned long.  */
-#undef SIZEOF_UNSIGNED_LONG
-
-/* The number of bytes in a unsigned short.  */
-#undef SIZEOF_UNSIGNED_SHORT
-
-#include "custom.h"
-- 
1.8.5.3.11.g2401a3b

-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.roaringpenguin.com/pipermail/remind-fans/attachments/20140119/c953553a/attachment.pgp>


More information about the Remind-fans mailing list