[RP-PPPoE] IPv6 support

Insane Laughing Clown mike-rppppoe at tiedyenetworks.com
Tue Jul 30 13:57:05 EDT 2013


On 07/30/2013 10:19 AM, David F. Skoll wrote:
> On Tue, 30 Jul 2013 09:35:53 -0700
> Insane Laughing Clown<mike-rppppoe at tiedyenetworks.com>  wrote:
>
>> The processing of pppoe control frames is single threaded and is
>> hindered by linear table lookups,
>
> As far as I remember, pppoe-server.c does not do linear table lookups,
> but just direct array offset calculations.
>
Two functions use a linear lookup - count_sessions_from_mac and 
pppoe_free_sessions.


> I am not a kernel programmer, so it could be that the kernel does
> linear lookups for PPPoE sessions, though that would surprise me.
>

I believe the kernel is using the jenkins hash for managing it's 
internal tables. Its quite efficient.

> Your point about single-threaded handling of control frames is valid,
> though.
>

-ILC



More information about the RP-PPPoE mailing list