[RP-PPPoE] pppoe-server efficiency (was Re: IPv6 support)

[David F. Skoll]

On Tue, 30 Jul 2013 14:11:03 -0400
"David F. Skoll" <dfs at roaringpenguin.com> wrote:

> That's true.  count_sessions_from_mac isn't called unless you use the
> -x option, and pppoe_free_session is only called when a session
> terminates, not for each control frame.

> Nevertheless, on a busy server those functions {c,sh}ould be changed
> to use hash lookups.

Ah... actually, pppoe_free_session could be made to run in constant time
by using a doubly-linked list of sessions instead of a singly-linked
list.  That just leaves count_sessions_from_mac that would need a
hash table.

Regards,

David.