[RP-PPPoE] PPPoE Server Kernel support is not detected with IPv6

[Adrian Ban]

Hi,

I've found a little but in configure script which will not permit to 
correctly detect the kernel mode. I'm using kernel 3.10.7 and rp-pppoe 3.11
The config.log shows me this:

configure:4504: checking for Linux 2.4.X kernel-mode PPPoE support
configure:4535: gcc -o conftest -g -O2   conftest.c  >&5
In file included from /usr/include/linux/if_pppox.h:25:0,
                  from conftest.c:56:
/usr/include/linux/if_pppol2tp.h:46:22: error: field 'addr' has 
incomplete type
   struct sockaddr_in6 addr; /* IP address and port to send to */
                       ^
/usr/include/linux/if_pppol2tp.h:71:22: error: field 'addr' has 
incomplete type
   struct sockaddr_in6 addr; /* IP address and port to send to */
                       ^
configure:4535: $? = 1
configure: program exited with status 1
configure: failed program was:

The problem is that if_pppol2tp.h has IPv6 support but the test program 
for kernel support doesn't include in6.h:

checking for Linux 2.4.X kernel-mode PPPoE support... *no*

if test "$cross_compiling" = yes; then :
   ac_cv_linux_kernel_pppoe=no; $ECHO "cross-compiling, default: "
else
   cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h.  */
#include <sys/socket.h>
#include <net/ethernet.h>
*#include <linux/if.h>**
**#include <linux/in.h>**
**#include <linux/if_pppox.h>*
int main()
{
         if (socket(AF_PPPOX, SOCK_DGRAM, PX_PROTO_OE) >= 0) return 0; 
else return 1;
}

After I've added:
#include <linux/if.h>
#include <linux/in.h>
*#include <linux/in6.h>**
*#include <linux/if_pppox.h>

The test program is compiled correctly and detects the kernel mode:

checking for Linux 2.4.X kernel-mode PPPoE support... *yes*

configure:4504: checking for Linux 2.4.X kernel-mode PPPoE support
configure:4536: gcc -o conftest -g -O2   conftest.c  >&5
configure:4536: $? = 0
configure:4536: ./conftest
configure:4536: $? = 0
configure:4552: result: yes

This fix can be updated in the sources?


Best regards,

-- 
Adrian Ban
IP/MPLS Engineer
----------------------------------------
mobil: +40788388190
web: www.abtelecom.ro
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.roaringpenguin.com/pipermail/rp-pppoe/attachments/20130915/6494fed4/attachment.html>