[RP-PPPoE] 3.11 bug report

David Binderman dcb314 at hotmail.com
Fri Jul 18 06:41:04 EDT 2014


Hello there,

I switched on compiler flag -Wtype-limits and got the following:

common.c:176:16: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
common.c:177:16: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Source code is

    if (saved_uid < 0) saved_uid = geteuid();
    if (saved_gid < 0) saved_gid = getegid();

Suggest code rework.

Regards

David Binderman

 		 	   		  


More information about the RP-PPPoE mailing list