[RP-PPPoE] Unexpected connection termination - stray PADT

[Dianne Skoll]

Hi,

The comment on that list is wrong; it's not an RP-PPPoE bug.
We do check to make sure the PADT is for the right session,
that it's destined for our MAC and that the source is our
peer's MAC.

Relevant code is below.  The code has been this way
since July 13, 2001, so unless your router is running
truly ancient or forked-from-ancient software, it
isn't an RP-PPPoE bug.

Regards,

Dianne.

    /* It's a PADT, all right.  Is it for us? */
    if (packet->session != Connection->session) {
	/* Nope, ignore it */
	return;
    }
    if (memcmp(packet->ethHdr.h_dest, Connection->myEth, ETH_ALEN)) {
	return;
    }

    if (memcmp(packet->ethHdr.h_source, Connection->peerEth, ETH_ALEN)) {
	return;
    }